Don't check on category

John (J5) Palmieri johnp at redhat.com
Tue Nov 8 11:48:39 PST 2005


A patch was added awhile ago which was a quick fix but not the correct
one:

2005-08-31  Danny Kukawka <danny.kukawka at web.de>

        * fdi/information/10freedesktop/10-usb-music-players.fdi:
        Removed merge of not useful key info.category=portable_audio_player.
        This merge breakes the storage policy and prevent mount of USB storage
        players. See bug: https://bugzilla.novell.com/show_bug.cgi?id=113966

The real fix was to change the storage policy to match on capabilities
and not category.  Attached is a patch which does this.  As for the
merge of info.category I propose that we nuke this for every device and
only rely on capabilities.  It gets confusing and I can see apps in the
future running into a bug like this.

-- 
John (J5) Palmieri <johnp at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-0.5.4-match-on-capabilities.patch
Type: text/x-patch
Size: 552 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20051108/b50a8a2f/hal-0.5.4-match-on-capabilities.bin


More information about the hal mailing list