[PATCH] fix for non utf8 valid serial on storage devices

David Zeuthen david at fubar.dk
Thu Nov 10 11:15:41 PST 2005


On Thu, 2005-11-10 at 20:08 +0100, Danny Kukawka wrote:
> Hi,
> 
> this is a patch to fix problems with non utf8 valid serials from storage 
> devices. This is near the same code as for non valid volume labels. 
> Additionally we add the serial only if there is at least one valid character 
> left in the serial. Invalid characters replaced with '?'.
> 
> The reason: D-BUS accept only utf8 valid strings. If the string is invalid the 
> storage device won't be added to HAL. (see bug report: 
> https://launchpad.net/products/hal/+bug/2624)
> 
> This patch fixes also a compiler warning in hald/util.c
> 
> Please review.

Looks good to me. Thanks!

Cheers,
David




More information about the hal mailing list