[PATCH][RFC]Use a hash table for device properties, take 2.

Richard Hughes hughsient at gmail.com
Tue Sep 13 13:21:02 PDT 2005


On Mon, 2005-09-12 at 16:50 +0100, Richard Hughes wrote:
> On Sun, 2005-09-11 at 23:06 -0400, David Zeuthen wrote:
> > On Sat, 2005-09-03 at 20:25 +0200, Danny Kukawka wrote:
> > > On Friday 02 September 2005 16:45, Cornelia Huck wrote:
> > > > This patch converts the list of properties maintained in HalDevice to a
> > > > GHashTable. The only difference to the previous patch (see
> > > > http://lists.freedesktop.org/archives/hal/2005-August/003148.html) is the
> > > > avoidance of C99 initializers.
> > > >
> > > > Again, please review this patch carefully.
> > 
> > OK, I tested this and it looks good to me. Danny, Richard, did any of
> > you get a chance to test this? 
> 
> Well, I've patched my local copy, and it seems to run okay, but I can't
> say for sure if hal starts up any quicker (it's pretty quick anyway).
> Put it this way: the patch doesn't appear to have broken anything for
> me :-)
> 
> Richard.

Nope, cancel that. Running this patch today gave me this error (and
backing out the patch fixed it)

[root at localhost ~]# /usr/sbin/hald --daemon=no verbose=yes
--retain-privileges
missing x or y absolute axes
missing x or y absolute axes
missing x or y relative axes
missing x or y absolute axes
29943: arguments to dbus_connection_send_with_reply_and_block() were
incorrect, assertion "(error) == NULL || !dbus_error_is_set ((error))"
failed in file dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.
29943: arguments to dbus_connection_send_with_reply_and_block() were
incorrect, assertion "(error) == NULL || !dbus_error_is_set ((error))"
failed in file dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.
29943: arguments to dbus_connection_send_with_reply_and_block() were
incorrect, assertion "(error) == NULL || !dbus_error_is_set ((error))"
failed in file dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.
29943: arguments to dbus_connection_send_with_reply_and_block() were
incorrect, assertion "(error) == NULL || !dbus_error_is_set ((error))"
failed in file dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.
29943: arguments to dbus_connection_send_with_reply_and_block() were
incorrect, assertion "(error) == NULL || !dbus_error_is_set ((error))"
failed in file dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.
29943: arguments to dbus_connection_send_with_reply_and_block() were
incorrect, assertion "(error) == NULL || !dbus_error_is_set ((error))"
failed in file dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.
29943: arguments to dbus_connection_send_with_reply_and_block() were
incorrect, assertion "(error) == NULL || !dbus_error_is_set ((error))"
failed in file dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.
29943: arguments to dbus_connection_send_with_reply_and_block() were
incorrect, assertion "(error) == NULL || !dbus_error_is_set ((error))"
failed in file dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.
29943: arguments to dbus_connection_send_with_reply_and_block() were
incorrect, assertion "(error) == NULL || !dbus_error_is_set ((error))"
failed in file dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.
29943: arguments to dbus_connection_send_with_reply_and_block() were
incorrect, assertion "(error) == NULL || !dbus_error_is_set ((error))"
failed in file dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.
29943: arguments to dbus_connection_send_with_reply_and_block() were
incorrect, assertion "(error) == NULL || !dbus_error_is_set ((error))"
failed in file dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.
29943: arguments to dbus_connection_send_with_reply_and_block() were
incorrect, assertion "(error) == NULL || !dbus_error_is_set ((error))"
failed in file dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.

** (process:29929): CRITICAL **: hal_property_get_strlist: assertion
`prop->type == HAL_PROPERTY_TYPE_STRLIST' failed

Not sure why.

Nak :-)

RIchard.



More information about the hal mailing list