system.formfactor never set for PMU

David Zeuthen david at fubar.dk
Tue Sep 20 08:25:58 PDT 2005


On Tue, 2005-09-20 at 14:29 +0100, Richard Hughes wrote:
> David,
> 
> For PowerMac based machines, system.formfactor is never set to anything
> other than "unknown".
> GNOME Power Manager has to know what type of machine we are to switch on
> the power-saving calls, as discussed previously.
> 
> Patch attached that sets this if we have a battery bay, as suggested by
> Matthew Garrett.
> 
> ChangeLog:
> 
> hald/linux2/pmu.c (pmu_synthesize_hotplug_events): Set the key
> system.formfactor to "laptop" if we have a battery bay.
> 
> Okay to commit?

Looks good to me, thanks!

Cheers,
David




More information about the hal mailing list