Brightness support for "sonypi" supported laptops
Richard Hughes
hughsient at gmail.com
Thu Apr 27 00:14:06 PDT 2006
On Thu, 2006-04-27 at 00:33 +0100, Bastien Nocera wrote:
> On Wed, 2006-04-26 at 23:03 +0100, Richard Hughes wrote:
> > On Wed, 2006-04-26 at 22:54 +0100, Bastien Nocera wrote:
> > > OK to commit? (not that I have rights to commit in hal)
> >
> > Looks okay to me, although that IRQ code looks wacky (but I see why it's
> > required), so no problem.
>
> The values are stolen from the sonypi module, and won't work in one
> particular case where the device will not have an IRQ (if I understood
> the code correctly). Better that it doesn't work on some machines than
> claiming to work and not doing so :)
Sure, agreed.
> 2006-04-26 Richard Hughes <richard at hughsie.com>
>
> Patch from Bastien Nocera <hadess at hadess.net>:
>
> * hald/linux2/acpi.c: (laptop_panel_refresh),
> (acpi_synthesize_sonypi_display),
> (acpi_synthesize_hotplug_events):
> Create an LCD Panel object of type sonypi, necessary for getting
> the
> methods supported for panasonic notebooks.
> ^^^^^^^^^
> did you mean sony? :)
I'll change it on my next commit, sorry!
Richard.
More information about the hal
mailing list