[PATCH 1/3] CPU frequency scaling addon

[Holger Macht]

On Sun 13. Aug - 15:00:39, Holger Macht wrote:
> On Sun 13. Aug - 13:44:53, Bastien Nocera wrote:
> > On Fri, 2006-08-11 at 19:45 +0200, Holger Macht wrote:
> > > Patch adding the cpufreq addon itself.
> > > 
> > > This version implements the following new things:
> > > 
> > >   - specific DBus errors on failure (exceptions)
> > >   - PolicyKit integration
> > >   - add DBus method to get a list of all available governors
> > > 
> > > Signed-off-by: Holger Macht <hmacht at suse.de>
> > > ---
> > > 
> > <snip>
> > > +/********************* userspace interface *********************/
> > > +static gboolean write_speed(unsigned kHz, int cpu_id)
> > > +{
> > > +	GString  *speed_file = g_string_new("");
> > > +	gboolean ret = TRUE;
> > > +
> > > +	if (!cpu_online(cpu_id)) {
> > > +		ret = FALSE;
> > > +		goto Out;
> > > +	}
> > > +
> > > +	g_string_printf(speed_file, SYSFS_SCALING_SETSPEED_FILE, cpu_id); 
> > 
> > That should be:
> > char *speed_file;
> > 
> > speed_file = g_strdup_printf (SYSFS_SCALING_SETSPEED_FILE, cpu_id);
> > <do stuff>
> > g_free (speed_file);
> > 
> 
> Thanks, this is better. Will change at corresponding places.

Done. New patch attached.

Regards,
	Holger
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-addon-cpufreq.patch
Type: text/x-patch
Size: 59270 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20060814/6088dd9f/hal-addon-cpufreq-0001.bin