[PATCH 1/3] CPU frequency scaling addon

David Zeuthen david at fubar.dk
Mon Aug 14 14:32:11 PDT 2006


On Sat, 2006-08-12 at 09:31 +0100, Richard Hughes wrote:
> Are we doing doxygen in HAL now, or gtk-doc style comments? David?

We use gtk-doc but it's not really mandatory expect for the exported
helper libraries. It might be at some point, so sticking to gtk-doc
format is probably a good idea.

> > +void free_cpu_load_data()
> > +{
> 
> Maybe I'm wrong, but I thought general hal CodingStyle was:
> 
> void
> free_cpu_load_data (void)
> 
> David, what do you say, (as I also have a patch from Kay that I'm
> waiting to send to the list and want to be correct.)

Yah, use spaces between function names and beginning paranthesis.

> free (foo);
> 
> rather than,
> 
> free(foo);

Ideally just use g_free() but that means allocating with g_new0() and
pulling in glib. But the latter is generally a good idea...

    David




More information about the hal mailing list