[PATCH] remove shared.h for addons/prober

David Zeuthen davidz at redhat.com
Mon Aug 21 10:21:56 PDT 2006


Hi,

(hmm, this mail only made it to my davidz at redhat.com subscription, not
my david at fubar.dk one. Maybe the list server have some issues?)

On Mon, 2006-08-21 at 15:09 +0200, Danny Kukawka wrote:
> Hi,
> 
> now the new version of my patch to remove hald/linux2/probing/shared.h. This 
> are the major changes:
> 
> * removed shared.h and switched addons and prober to use with logger.[c,h] 
>   the same functions and format as the hal daemon.
> * split off powermanagement related code from util.c/h to a new file 
>   util_pm.[c,h].
> * added a new file util_helper.[c,h] to collect functions drop_privileges() 
>   and hal_set_proc_title*().
> * removed unused function strdup_valid_utf8() from probe-storage.c and 
>   updated hal_util_strdup_valid_utf8() to do the same as strdup_valid_utf8() 
>   before.
> * fixed compiler warning in ids.c (use now *_ids_free() functions instead of 
>   call free() directly without checks).
> * fixed compiler warning in addon-macbookpro-backlight.c (added '#if 0' around 
>   unused function)
> 
> Please review.

Looks good to me. Thanks a lot!

Cheers,
David




More information about the hal mailing list