[PATCH 1/3] CPU frequency scaling addon

[David Zeuthen]

On Tue, 2006-08-22 at 01:34 +0200, Holger Macht wrote:
> I've attached a new version of the patch that builds and applies against
> current HEAD.

Great, sorry for taking so long to review it. 

I've committed it with one change, 

 http://gitweb.freedesktop.org/?p=hal.git;a=commit;h=f0471f48cdb4a8c2826e6050d69e407823af15c8

to make introspection work and save some roundtrips on start up. Also,
D-Bus got standard infrastructure for invalid messages etc., so I
changed your code to use that, see

 http://gitweb.freedesktop.org/?p=hal.git;a=commit;h=39024923e8920736221f28bb01d8ade84a0afd2e

Oh, and, using the userspace governor works great for me. It's a bit
chatty on the debug output though - any chance you can disable it for
now just when running as 'userspace'? [1]

This might be unrelated to your patch, I think it is... So.. when
choosing the 'performance' governor, however, my Intel Core Due on my
Macbook Pro bumps the CPU usage to a constant 2GHz on each core. Is that
expected? Or a bug in the built-in performance governor in the kernel?

Thanks again, Cheers,
David

[1] : ideally, some day, we'd have domains for logging so we can use
D-Bus to poke the daemon to turn debug on / off for specific logical
domains of all the code. So I could e.g. turn on debug output for the
cpufreq addon and the storage addon for /dev/sdb. Or something.