[PATCH][RFC] recursion reduction patch
Danny Kukawka
danny.kukawka at web.de
Wed Dec 13 08:27:55 PST 2006
On Wednesday 13 December 2006 17:00, Sergey Lapin wrote:
> Hi,
> attached patch is removal of 2 major recursion paths. It does not
> removes all recursion but makes it not harmful. On my device it reduced
> stack consumption from ~170K to ~80K (12K RSS).
Without a deeper look at the patch: Why do you need a new out2 if out do the
same?:
@@ -345,14 +348,14 @@ add_blockdev_probing_helper_done (HalDev
hal_device_store_remove (hald_get_tdl (), d);
g_object_unref (d);
hotplug_event_end (end_token);
- goto out;
+ goto out2;
@@ -383,6 +386,8 @@ add_blockdev_probing_helper_done (HalDev
out:
return;
+out2:
+ ;
}
More information about the hal
mailing list