[PATCH][RFC] FDI mmap optimization
David Zeuthen
david at fubar.dk
Thu Dec 14 19:24:17 PST 2006
Sergey Lapin wrote:
> Danny Kukawka wrote:
>> Anyway, on the first lock at the patch I would say this part is not
>> the best idea:
>> + if((tmpdir = getenv("TMPDIR")) == NULL) {
>> + tmpdir = "/tmp";
>> + }
>> + cachename = g_strconcat(tmpdir, "/fdi_cache", NULL);
>>
>> IMO hal should create such a file better e.g. under /var/run/hal/ or
>> /var/tmp
>
> will configure option like --with-mmap-cache-dir to set it be appropriate?
I think ${localstatedir}/run/hal/fdi-cache would be appropriate. Adding
more build time configuration options is probably not right. Thanks.
David
More information about the hal
mailing list