gnome-mount patch

[Jeffrey Stedfast]

On Tue, 2006-02-07 at 21:04 -0500, David Zeuthen wrote:
> On Tue, 2006-02-07 at 15:10 -0500, Jeffrey Stedfast wrote:
> > I'm not sure if this is the proper place to send gnome-mount patches but
> > eh.
> 
> Oh, this is fine though I think utopia-list at gnome.org is more
> appropriate. I've added this as Cc.
> 
> > The attached patch simplifies stuff a bit by using a GPtrArray to create
> > the mount options char** rather than first creating a GSList and then
> > converting that into a char**.
> 
> Looks good.
> 
> > I also took the liberty of fixing one of the TODO's (limit what options
> > you use based on what is available in HAL) and also implemented user
> > options (altho #if 0'd out for now until we figure out what gconf key
> > scheme to use).
> 
> Cool. Right, yea, I think we should store the mount options as text
> strings because it is at least per-kernel and probably also per-distro
> given distros carry different patches. Regarding the scheme I was
> thinking something along the lines of
> 
>  /system/storage/volumes/<udi>/mount_options  : list of strings
>                                mount_location : string

these sound as good as any

> 
> We should probably somehow take the union of a) the retrieved mount
> options for the specific volume; and b) the valid options... and use
> that as mounting. Should probably write to syslog if one of the options
> in a) isn't in b). 

seems reasonable (I was wondering if we should do something like that as
well, but didn't have any idea how to present that to a user - a syslog
might be the way to go - a dialog seems too intrusive)

> 
> It might also be useful to think about having the default mount options
> in gconf, probably something like
> 
>  /system/storage/volume-defaults/<fstype>/mount_options

seems reasonable

> 
> would do. Btw, I started writing a nautilus extension for editing this
> (the thinking is to add a property page per volume) but that is
> currently blocking on a bug in Nautilus
> 
>  http://bugzilla.gnome.org/show_bug.cgi?id=329426
> 
> 
> > I also fixed some repeat type-o's
> >
> > if (reply = NULL)
> > 
> > which should have been
> > 
> > if (reply == NULL)
> 
> Hehe, ugh, I shouldn't write code late at night..

:)

> 
> > 
> > 
> > Okay to commit?
> 
> Sure, go ahead, thanks.

if I get the time, I might see about implementing some of your other
ideas.

-- 
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
fejj at ximian.com  - www.novell.com