Small fix for capability check in hald_dbus.c
David Zeuthen
david at fubar.dk
Sat Feb 18 09:47:19 PST 2006
Hi,
Sorry for the lag,
On Tue, 2006-02-14 at 12:15 +0100, Martin Pitt wrote:
> Hi!
>
> We recently got a bug report in Ubuntu [1] about a hal crash when
> calling hal.device.QueryCapability(). The bug reporter proposed a nice
> patch which drops the info.capabilities iteration loop and just uses a
> single hal_device_has_capability() call.
>
> Apparently this bit of code has recently been fixed in cvs head as
> well, so that the actual bug might be gone as well. However, I still
> think that the attached patch is easier and more elegant and avoids
> code duplication.
>
> What do you think?
Actually I like to keep the code as is because someday libhal will cache
properties and then we'll save a round trip to the daemon. Thanks
anyway.
Cheers,
David
More information about the hal
mailing list