[julien@kirya.net: Bug#353181: hal: Please add support for hibernate/suspend2 suspend-to-ram]

[Richard Hughes]

On Tue, 2006-02-21 at 10:57 +1000, Nigel Cunningham wrote:
> Hi.
> 
> On Monday 20 February 2006 09:17, Richard Hughes wrote:
> > On Mon, 2006-02-20 at 00:06 +0100, Sjoerd Simons wrote:
> > > Patch below let's suspend2 suspend to ram. Now i don't know if
> > > /etc/hibernate/ram.conf is a default file for the hibernate program or
> > > specific to the debian package though ?
> > >
> > > ----- Forwarded message from Julien Valroff <julien at kirya.net> -----
> > >
> > > Date: Thu, 16 Feb 2006 19:01:49 +0100
> > > From: Julien Valroff <julien at kirya.net>
> > > Subject: Bug#353181: hal: Please add support for hibernate/suspend2
> > > suspend-to-ram To: Debian Bug Tracking System <submit at bugs.debian.org>
> > > Reply-To: julien at kirya.net, 353181 at bugs.debian.org
> > > X-Mailer: reportbug 3.18
> > >
> > > --- hal-system-power-suspend~	2006-02-13 18:25:07.000000000 +0100
> > > +++ hal-system-power-suspend	2006-02-13 18:25:50.000000000 +0100
> > > @@ -49,6 +49,10 @@
> > >  	if [ -x "/usr/bin/powersave" ] ; then
> > >  	    $POWERSAVED_SUSPEND2RAM
> > >  	    RET=$?
> > > +	elif [ -x "/usr/sbin/hibernate" ] ; then
> > > +	    # Use hibernate configured for suspend-to-ram
> > > +	    /usr/sbin/hibernate -F/etc/hibernate/ram.conf
> > > +	    RET=$?
> >
> > What happens if you omit the ram.conf? Can you just trigger a suspend
> > using the default script some other way?
> 
> Without -F/path/to/conf-file, it will default 
> to /etc/hibernate/hibernate.conf, which is usually (but not necessarily) used 
> for starting a suspend to disk cycle. The nicest option might be to make the 
> config file to use configurable, if this isn't too much of a pain.

Is -F/path/to/conf-file consistent between distros? i.e. would:
/usr/sbin/hibernate -F/etc/hibernate/ram.conf work on ubuntu, fedora,
gentoo etc?
If it is, then I see no problems with the patch, but if not we should
probably test for the config file (if [ -x "/etc/hibernate/ram.conf" ])
before we execute hibernate.

Richard.