[PATCH] Re: probe-serial.c does not work on /dev/ttyACM0

[Danny Kukawka]

On Thursday 16 February 2006 21:45, Kay Sievers wrote:
> Hi Pierre,
> did you test the serial prober with anything but plain old serial
> ports? I seems to fail with serial USB devices, common in mobile
> phones:
>    open("/dev/ttyACM0", O_RDONLY|O_NONBLOCK|O_LARGEFILE) = 3
>    ioctl(3, TIOCGSERIAL, 0xbff5029c) = -1 EINVAL (Invalid argument)

I checked this and discussed this here Hannes Reinecke. Only ttyS* devices 
support TIOCGSERIAL - all other tty-devices as e.g. ttyACM* and ttyUSB* does 
not support the command. 

See attached patch. I fixed serial_get_prober - now the serial prober is only 
called for ttyS* devices.

Please review.

Cheers,

Danny

 classdev.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletion(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-fix-get_prober_serial.diff
Type: text/x-diff
Size: 402 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20060222/961fbb5c/hal-fix-get_prober_serial.bin