[PATCH] sanitize instead of rejecting mountpoints with funny characters

Bill Nottingham notting at redhat.com
Mon Feb 27 11:31:26 PST 2006


David Zeuthen (david at fubar.dk) said: 
> > Probably should check for anything valid in the system locale
> > (i.e., accept non-ascii UTF-8 in en_US.UTF-8)
> 
> So I nearly completed the rewrite of this helper in C yesterday... will
> probably commit the code tomorrow night or earlier if I get time.
> 
> I think accepting anything that doesn't have G_DIR_SEPARATOR (e.g. '/')
> is sound, yes? Or should we explicitly forbid more stuff?

If it's valid UTF-8, I don't think anything other than '/' needs escaped,
unless there's some weird issue with passing the name to scripts and
getting shell-quoted stuff executed.

Bill


More information about the hal mailing list