[PATCH] 0.5.5.1 - usw O_NONBLOCK for CD-ROM in probe-volume.c

[Andrey Borzenkov]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Wednesday 04 January 2006 15:54, Danny Kukawka wrote:
> On Wednesday 04 January 2006 11:55, Andrey Borzenkov wrote:
> > Else probing fails with dev.cdrom.check_media enabled.
>
> Hm ... Which key/property do you mean? Maybe
> storage.media_check_enabled=true for CD/DVD devices?
>

Sorry, this is Linux CD-ROM driver parameter, dev.cdrom.check_media is Linux 
ioctl name get/set it.  Parameter itself is called check_media_type IIRC.

> What exactly is the problem with this property. This is IMO automatically
> actived for CD/DVD devices and I had never problems with probing volumes
> for CD/DVD volumes. Would be nice to know more about the problem/effects.
>

If check_media_type is enabled open without O_NONBLOCK fails if CD does not 
contain data tracks. It means that probing for audio and other non-data CD 
fails because HAL never gets as far as checking type.

I have it enabled from the time I used supermount (otherwise supermount was 
badly confused by non-data CDs). It is off by default that is probably the 
reason why you never noticed it before.

- -andrey
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDvrWHR6LMutpd94wRAnLQAKCmHQcUVWDZ/Vog0jmCQYgL7/hauwCfZlLL
XSm3SrpeDvtAysubcG1Wjw8=
=EadT
-----END PGP SIGNATURE-----