[gpm] Untangling the sleep hotkey mess
Richard Hughes
hughsient at gmail.com
Sun Jan 8 17:21:36 PST 2006
On Mon, 2006-01-09 at 09:10 +0800, Yu Luming wrote:
> > 3. Use the new acpi kernel hotkeys stuff -- not that I really understand
> > the interface, nor how to use it correctly. Plus I'm not sure how much
> > of the vendor kernel modules can use this new interface, or if it's
> > suitable. It all seemed a bit fragile last time I looked.
>
> Please take a look at
> http://bugzilla.kernel.org/show_bug.cgi?id=5749
>
> There are some examples to use hotkey.c for specific laptops with dedicated
> hotkey acpi device objects , and dedicated AML methods.
> This patch: http://bugzilla.kernel.org/show_bug.cgi?id=5749#c3
> can be used to replace sony_acpi.c
>
> This patch: http://bugzilla.kernel.org/show_bug.cgi?id=5749#c4
> can be used to support brightness control for panasonic laptop.
>
> This patch: http://bugzilla.kernel.org/show_bug.cgi?id=5749#c5
> can be used to support brighness contrl for ASUS laptop.
>
> Please notes, I will update these patch against len's testing tree, and
> ask for inclusion.
Why do we want to use the new hotkey stuff when we can just process all
the events in userspace using acpi events? The hotkey stuff seems
overcomplicated and fragile in my opinion.
Sending and receiving :::data:in:some::odd:format seems a little unusual
to me when we can just listen for the event in one place (like HAL) --
but then maybe I don't understand all the details. It's not like we will
have different programs registering for different acpi button events,
right?
Richard.
More information about the hal
mailing list