link storage prober against external libvolume_id

David Zeuthen david at fubar.dk
Sat Jul 22 08:41:23 PDT 2006


On Fri, 2006-07-14 at 23:23 +0100, Richard Hughes wrote:
> On Sat, 2006-07-08 at 02:13 +0200, Kay Sievers wrote:
> > Here we get rid of the private copy of libvolume_id and depend on the
> > shared library, provided by the udev package.
> > The copy in the tree should be removed as it is no longer maintained
> > and already a bit behind the udev version.
> 
> ./autogen.sh fails:
> config.status: error: cannot find input file: volume_id/Makefile.in
> 
> Trivial patch attached - okay to commit?

Go for it, thanks.

> 
> I also get on 'make distcheck':
> 
> Validate XML in 10-laptop-panel-mgmt-policy.fdi : failed
> ../../../../fdi/policy/10osvendor/10-laptop-panel-mgmt-policy.fdi:40:
> element match: validity error : Element match content does not follow
> the DTD, expecting (match | merge | prepend | append | remove)*, got
> (spawn )
> ../../../../fdi/policy/10osvendor/10-laptop-panel-mgmt-policy.fdi:41:
> element spawn: validity error : No declaration for element spawn
> ../../../../fdi/policy/10osvendor/10-laptop-panel-mgmt-policy.fdi:41:
> element spawn: validity error : No declaration for attribute udi of
> element spawn
> Document ../../../../fdi/policy/10osvendor/10-laptop-panel-mgmt-policy.fdi does not validate against ../../../../fdi/fdi.dtd
> make[4]: *** [check] Error 1
> 
> Which I'm guessing spawn has to be added to the dtd, but I'm no expert
> in SGML, so I'll leave that to someone that is.

I'll do a distcheck soon to fix this.

Cheers,
David




More information about the hal mailing list