[PATCH] fix DBusError leaking libhal and libhal-storage

Danny Kukawka danny.kukawka at web.de
Thu Jul 27 04:02:13 PDT 2006


On Sunday 23 July 2006 23:57, David Zeuthen wrote:
> On Sat, 2006-07-22 at 21:51 +0200, Danny Kukawka wrote:
> > On Saturday 22 July 2006 17:08, David Zeuthen wrote:
[...]
> I think the patch you wrote with a warning to stderr if the macro is
> used incorrectly is the way to go.

New version attached. I changed the position of some macro calls and removed 
in mopts_collect() a needless 'goto error' and the related call of 
libhal_free_property_set() because 'properties' is NULL in the error case.

Danny

 ChangeLog                       |   22 ++++++++++++
 libhal-storage/libhal-storage.c |   54 ++++++++++++++++++++++--------
 libhal/libhal.c                 |   11 +++++-
 libhal/libhal.h                 |   12 ++++++
 4 files changed, 84 insertions(+), 15 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-fix-memoryleak_libhal-libhal-storage_187108_v2.diff
Type: text/x-diff
Size: 9763 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20060727/ad449748/hal-fix-memoryleak_libhal-libhal-storage_187108_v2.bin


More information about the hal mailing list