bustypes wrong in probing/probe-input.c

[Johannes Berg]

My version (slightly older) of probe-input.c contains:

                switch (id.bustype) {
                case 17: /* TODO: x86 legacy port; use symbol instead of hardcoded constant */
                case 21: /* BUS_HOST, not hotpluggable */
                case 23: /* ADB on Apple computers */
                        break;
                default:
                        goto out;
                }

So far, so good. I had BUS_HOST for my new PMU event patch that is going
to be in the kernel... Now, it doesn't work and I started pulling my
hair out until I realised that the comment above is bogus.

linux-2.6/include/linux/input.h:
#define BUS_HOST                0x19

which obviously doesn't equal 21 but 25.

If 21 is needed (it is BUS_PARPORT btw) then please fix the comment and
actually add BUS_HOST (25) to the list please.

Unless it's all been fixed and I just didn't notice because my version
is still too old. Not all that unlikely, if so sorry for the noise.

johannes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 793 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/hal/attachments/20060620/336529d9/attachment.pgp