Have addon-keyboard recognize some more buttons

Richard Hughes hughsient at gmail.com
Wed Mar 1 09:09:11 PST 2006


On Wed, 2006-03-01 at 18:01 +0100, Sjoerd Simons wrote:
> On Wed, Mar 01, 2006 at 04:19:37PM +0000, Richard Hughes wrote:
> > On Wed, 2006-03-01 at 15:56 +0100, Sjoerd Simons wrote:
> > > >       [KEY_POWER] = "power",
> > > >       [KEY_MUTE] = "mute",
> > > >       [KEY_VOLUMEDOWN] = "volumedown",
> > > >       [KEY_VOLUMEUP] = "volumeup",
> > > >       [KEY_KBDILLUMTOGGLE] = "kbdillumtoggle",
> > > >       [KEY_KBDILLUMDOWN] = "kbdillumdown",
> > > >       [KEY_KBDILLUMUP] = "kbdillumup",
> > > >       [KEY_SWITCHVIDEOMODE] = "switchvideomode"
> > 
> > Shouldn't this be:
> > 
> > volume_down
> > brightness_up
> > switch_video_mode?
> > 
> > kbdillumup seems a bit odd to me.
> 
> Agreed. I just followed the convention of brightnessup. If we want to change
> it, we should do it _now_ as almost uses them currently. 

I think lower case words separated with a _ is the best way.

Richard.



More information about the hal mailing list