Add a simple version of the toshiba acpi addon
Richard Hughes
hughsient at gmail.com
Wed Mar 1 10:52:59 PST 2006
On Wed, 2006-03-01 at 19:36 +0100, Sjoerd Simons wrote:
> On Wed, Mar 01, 2006 at 06:08:29PM +0000, Richard Hughes wrote:
> > + else if (value == 0x140) /* FnF6 */
> > + result = "brightness_down";
> > + else if (value == 0x141) /* FnF7 */
> > + result = "brightness_up";
> > + else if (value == 0x142) /* FnF8 */
> > + result = "wifi_power";
>
> The naming here is another convention as what's currently in the keyboard
> addon. So we really need to decide which we we're gonna use. I'm for the
> ``new'' version, because it's a lot nicer to read :) David?
Yes, something like eject_close_cd is much easier to read than
ejectclosecd in my opinion.
David, if you want I can patch the keyboard addon with "new names" --
note g-p-m has only ever supported the "new" syle (brightness_up), and I
don't think anything else uses this yet. Matthew, correct me if I'm
wrong.
Richard
More information about the hal
mailing list