[PATCH] to avoid possible blocking hald if stat nfs share mounts

David Zeuthen david at fubar.dk
Mon May 8 07:52:38 PDT 2006


On Fri, 2006-05-05 at 17:19 +0200, Danny Kukawka wrote:
> Hi,
> 
> this patch avoid blocking hald and all hal using applications if there is a 
> nfs share with 'stale nfs handle'. Simply never stat nfs mounts (at least, 
> because HAL does not handle nfs mounts).
> 
> Please review.

Looks good with one change:

> +               if (!strcmp(mnt.mnt_type, "nfs"))

It would be a lot easier to read this if you did 

 if (strcmp (mnt.mnt_type, "nfs") == 0)

since strcmp returns a signed integer, not a boolean.

Thanks,
David



More information about the hal mailing list