[PATCH] Ignore heavily broken volume labels

David Zeuthen david at fubar.dk
Fri May 12 08:19:21 PDT 2006


On Wed, 2006-05-10 at 18:35 +0200, Martin Pitt wrote:
> Hi!
> 
> In Ubuntu we got several bug reports about device label gibberish, for
> example: https://launchpad.net/bugs/27897
> 
> This happens if the label is either truly bogus, or in a non-UTF-8
> compatible encoding. 
> 
> The blunt solution would be to just ignore any non-UTF-8 labels, but
> since it might be preferable to retain labels which are only 'lightly'
> damaged (maybe one Umlaut in an otherwise valid string), I wrote a
> small patch to ignore invalid labels if they contain more than 20%
> illegal characters.
> 
> Is that something you would consider to do for upstream?

Sure, it makes sense. I've committed a fixed up version since it didn't
apply after Danny's changes. Thanks.

    David




More information about the hal mailing list