Look who's a committer now

[Joe Marcus Clarke]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David Zeuthen wrote:

>     This requires 
> 
>      - hald-runner to set HAL_UNAME_S to `uname -s` (need patch) and I
>        think that's fine; saves invocation of /bin/uname on every script
>        and while we're at lowercase the string too.

uname -s, or can I just use the uname(3) function?

> 
>      - I'm assuming that the script being exec'ed inherits
>        stdin/stdout/stderr; I think that's true too and we need it for
>        the arguments passed
> 
>      - tools/$OS to install scripts in the same place
> 
>     Of course, some scripts are simple and we don't need to exec an OS
>     specific script. Also, some stuff in C like hal-storage-mount.c
>     should just be patched so it works on FreeBSD and Solaris too. That
>     shouldn't be a problem because it's C. Finally, some scripts we can
>     just switch on HAL_UNAME_S directly in the script.

Okay.  That will make things easier with the patches we already have.
They can mostly be committed as-is.

> 
>     The big wins we get is that 1) we don't need OS-conditionals in the
>     fdi files (we really really don't want that); and 2) we centralize
>     all shared checking in one place.

This I don't follow.  The tools stuff, sure, but what about the fdi
stuff?  How does this help the fdi files?  Are you saying we create OS
directories for them as well?

> 
>  2. tools/$OS contains the OS specific bits; so we would have
> 
>      tools/linux/hal-system-lcd-get-brightness-linux
>      ...
>      tools/freebsd/hal-system-lcd-get-brightness-freebsd
>      ...
>      tools/solaris/hal-system-lcd-get-brightness-freebsd
> 
>     and that's it. Obviously you don't install tools/linux on
>     FreeBSD and so forth.
> 
>> Once I get the tools compartmentalized, I will start work on merging the
>> FreeBSD-specific patches into our tools directory.
>>
>> Is this something I can get permission to do?  If so, do you guys do the
>> repocopy thing, or should I just cvs rm/cvs add?  Thanks.
> 
> I think with the approach I've outlined above we don't need to move
> anything. 
> 
> Thoughts?

I agree, this sounds like a good approach.

Joe

> 
>     David
> 
> 
> _______________________________________________
> hal mailing list
> hal at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/hal
> 


- --
Joe Marcus Clarke
FreeBSD GNOME Team	::	gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEZMahb2iPiv4Uz4cRAv1JAJ9yVU1F8zdZaBvbcyaIpjR4TKkqxwCgip/p
eh1I86vQMh1/Xy4UEl01K14=
=S+AT
-----END PGP SIGNATURE-----