volume unmounting/ejecting broken on linux

[William Jon McCann]

Hi,

Danny Kukawka wrote:
> On Wednesday 17 May 2006 17:38, William Jon McCann wrote:
> [...]
> 
>>With that change it was clear that the problem was indeed not finding
>>the backend script.  Your patch fixed that problem.
>>
>>Then I found that the backend unmount script did not have the
>>MOUNT_POINT variable defined.  It should be exported in the parent script.
>>
>>The attached patch should fix it.
> 
> I update the patch. I moved the check for MOUNT_POINT to the top of the 
> script, we can exit directly if MOUNT_POINT is missing. I also fixed eject 
> and added GIVEN_EJECTOPTIONS to the eject command and removed the rc=0 line 
> (I don't know why this line was there.).
> 
> Could someone test this?

Almost but the GIVEN_EJECTOPTIONS shouldn't be quoted or eject will fail 
with a too many options error.

Here's an update that fixes that and three other things.
1. The output from polkit-is-privileged must be captured or else it will 
mess up error reporting in the scripts.  It certainly produces a message 
if the command is not found.
2. Add the PACKAGE_BIN_DIR to the path so that polkit-is-privileged will 
be found if installing into a alternate root directory.
3. There was a missing UnknownError line before the backend not found 
message in hal-system-storage-cleanup-mountpoints

Jon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-fix-tools_scripts_v4.diff
Type: text/x-patch
Size: 15924 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20060517/b1fa9ccf/hal-fix-tools_scripts_v4.bin