[PATCH] FreeBSD backend
David Zeuthen
david at fubar.dk
Thu Nov 9 13:40:28 PST 2006
Hi,
Sorry for the lag, am in bug-fixing ville!
On Mon, 2006-11-06 at 13:14 -0500, Joe Marcus Clarke wrote:
> > Thanks for working on this. Some comments inline after briefly looking
> > at the patch... I'll look more at it later..
Btw, I'm going to do this in the weekend.
> > Any reason in particular you need all these paths? I think /usr/local
> > might make sense but I'm not sure why /usr/X11R6/* would be ever needed.
> > It's not like you'll have an X connection or helpers (callouts, method
> > calls etc.) should ever need to communicate with X.
>
> That's just the way FreeBSD is at the moment. We're trying to collapse
> into one PREFIX (/usr/local), but for now, we have stuff spread out over
> both. If you don't want this to be committed to HAL git, then it will
> become a local patch of ours.
Possibly you can do an #ifdef for now?
> > Oh, ok, this is for things like opening device files for receiving
> > events from the kernel? I guess that makes sense, yeah, it's just not
> > something we've been using on Linux...
>
> Actually, receiving kernel events can be done without root. We need
> this for opening /dev/pci, /dev/usb*, etc. Without this, HAL would not
> have nearly the same kind of detail that it does on FreeBSD. This is a
> lynch pin patch for us.
Sure, it's fine with me. I can see this being useful for other kernels
too.
So I think I'm somewhat happy with the patches that touches the shared
code so that's good to commit one by one (with the #ifdef for the
runner). You have a fd.o account yes? Also, Richard said he could help
you if you needed it.
I guess the FreeBSD specific code is good to commit too, I mean, it's
your code so feel free to commit it. I did notice a few weird things
(synchronously calling helpers) when briefly reading through it but I'll
follow up on that later.
Sounds good?
David
More information about the hal
mailing list