[PATCH] FreeBSD backend
Richard Hughes
hughsient at gmail.com
Fri Nov 10 03:24:37 PST 2006
On Fri, 2006-11-10 at 02:11 -0500, Joe Marcus Clarke wrote:
>
> Not ever making a git commit before in my life, I'd like Richard to do
> the global code if possible. I think there's less chance of my
> screwing
> up the backend commit (less chance of screwing up others, that is).
No problem. I'll do the diff in little commits so that davidz can revert
specific parts if need be.
One big thing that I noticed was the tabs and spaces - hal usually has:
if (foo) {
/* do bar */
exit (1);
}
rather than:
if (foo)
{
exit(0);
}
Is there any chance you could run your code through indent please - just
for consistency with the other code. I'll then start committing.
David - feel free to tell me I'm being anally-retentive, but I think we
should be consistent with the other code on such a large patchset.
Also, in hf-computer.c I see all the "Pizza Box" conversion code similar
to the linux stuff - this should probably be a function in util.c - I
can tidy this up if needed. I don't know if this is the case with the
solaris code also.
Thanks,
Richard.
More information about the hal
mailing list