[PATCH] remove usage of g_assert() in blockdev
Danny Kukawka
danny.kukawka at web.de
Mon Nov 13 09:15:14 PST 2006
Hi,
this patch removes the only one g_assert() within the complete daemon from
blockdev.c. I replaced this with code to check also the tdl instead of only
gdl and go to the (already existing) error case if HAL don't get the device
searching for and simply print a error mesage and don't add the device to the
device tree.
Without the fix HAL 'die' without any message sometimes on boot.
IMO the usage of g_assert() is not needed in this case. If HAL can't find the
device, there is no need to exit, at least not within the blockdev code.
Please review.
Danny
blockdev.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-fix_blockdev_g_assert.diff
Type: text/x-diff
Size: 548 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20061113/3dda2756/hal-fix_blockdev_g_assert.bin
More information about the hal
mailing list