Hardware recall data RFC

[David Zeuthen]

Hi Richard!

Richard Hughes wrote:
> Request for comments for spec addition:
> 
> <row>
>   <entry>
>     <literal>info.is_recalled</literal> (bool)
>   </entry>
>   <entry></entry>
>   <entry>No</entry>
>   <entry>
>     This is set if the hardware may be recalled and should
>     be checked for any potential problem.
>   </entry>
> </row>
> <row>
>   <entry>
>     <literal>info.recall.oem_vendor</literal> (string)
>   </entry>
>   <entry>dell, sony, hp, panasonic, etc.</entry>
>   <entry>Yes, if <literal>info.is_recalled</literal> is TRUE</entry>
>   <entry>
>     The OEM vendor responsible for the hardware recall.
>     The value should reflect the OEM vendor in lower case.
>   </entry>
> </row>

How about just

  info.recall.vendor

I don't like lower-case at all, it makes it look like the property is 
confined to only specific values and that things g-p-m is trying to be 
smart and map e.g. "sony" to a localized name (it shouldn't).

Also, suggest to drop 'oem' too.

> <row>
>   <entry>
>     <literal>info.recall.url</literal> (string)
>   </entry>
>   <entry></entry>
>   <entry>Yes, if <literal>info.is_recalled</literal> is TRUE</entry>
>   <entry>
>     Users should check this website for more details and if their
>     hardware may affected by any possible fault.
>   </entry>

Maybe a bit more specific, perhaps we want to include more than one URL 
in the future

  info.recall.website_url

>   <entry>
>     <literal>info.recall.description</literal> (string)
>   </entry>
>   <entry>VendorX Hardware Recall</entry>
>   <entry>Yes, if <literal>info.is_recalled</literal> is TRUE</entry>
>   <entry>
>     The recall description, suitable to show in the UI.
>   </entry>
> </row>

Would avoid doing this; it's not localized.

If you need to display the reason in the UI (which you should since you 
have info.recall.website_url) you need to define what values this 
variable can assume (including 'unknown') and describe the semantics of 
each value in the spec. Then you can include the localized text in e.g. 
in g-p-m.

I would just avoid doing it entirely.

      David