[PATCH] FreeBSD backend

[Joe Marcus Clarke]

On Thu, 2006-11-09 at 16:40 -0500, David Zeuthen wrote:
> Hi, 
> 
> Sorry for the lag, am in bug-fixing ville!
> 
> On Mon, 2006-11-06 at 13:14 -0500, Joe Marcus Clarke wrote:
> > > Thanks for working on this. Some comments inline after briefly looking
> > > at the patch... I'll look more at it later..
> 
> Btw, I'm going to do this in the weekend.
> 
> > > Any reason in particular you need all these paths? I think /usr/local
> > > might make sense but I'm not sure why /usr/X11R6/* would be ever needed.
> > > It's not like you'll have an X connection or helpers (callouts, method
> > > calls etc.) should ever need to communicate with X.
> > 
> > That's just the way FreeBSD is at the moment.  We're trying to collapse
> > into one PREFIX (/usr/local), but for now, we have stuff spread out over
> > both.  If you don't want this to be committed to HAL git, then it will
> > become a local patch of ours.
> 
> Possibly you can do an #ifdef for now?
> 
> > > Oh, ok, this is for things like opening device files for receiving
> > > events from the kernel? I guess that makes sense, yeah, it's just not
> > > something we've been using on Linux...
> > 
> > Actually, receiving kernel events can be done without root.  We need
> > this for opening /dev/pci, /dev/usb*, etc. Without this, HAL would not
> > have nearly the same kind of detail that it does on FreeBSD.  This is a
> > lynch pin patch for us.
> 
> Sure, it's fine with me. I can see this being useful for other kernels
> too.
> 
> So I think I'm somewhat happy with the patches that touches the shared
> code so that's good to commit one by one (with the #ifdef for the
> runner). You have a fd.o account yes? Also, Richard said he could help
> you if you needed it.
> 
> I guess the FreeBSD specific code is good to commit too, I mean, it's
> your code so feel free to commit it. I did notice a few weird things
> (synchronously calling helpers) when briefly reading through it but I'll
> follow up on that later.

I went ahead and changed the style of the FreeBSD backend to more
closely match the rest of the HAL code.  I have noticed that the global
changes have not been merged yet.  Should I just go ahead and do them
along with the rest of the FreeBSD backend changes?

The new diff is up at
http://www.marcuscom.com/downloads/freebsd_hal_git.diff .

Joe

-- 
Joe Marcus Clarke
FreeBSD GNOME Team      ::      gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freedesktop.org/archives/hal/attachments/20061119/677a9ec3/attachment.pgp