HAL 0.5.7 -> 0.5.8 API changes (and subtle breakage heh)

Milosz Derezynski internalerror at gmail.com
Mon Nov 27 05:35:44 PST 2006


There are several occasions in which a function argument called index
shadows declarations from header files (string.h), but i can't see why the
member name of the _struct_ was renamed.

If anything at all, then to go with other renamings from index to "idx", but
there is really no other reason than this consistency (in code), which
weighs much less than consistency of the API, especially since the PS iter
is not marked private, and addtionally since this is just a minor change
that wouldn't have had to be made.

On 11/27/06, David Weinehall <david.weinehall at nokia.com> wrote:
>
> On sön, 2006-11-26 at 20:54 +0100, ext Milosz Derezynski wrote:
> [snip]
>
> > ("index" was renamed to "idx")
>
> Try compiling with -Wshadow, and you'll (hopefully) realise why.
>
>
> Regards: David Weinehall
> _______________________________________________
> hal mailing list
> hal at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/hal
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.freedesktop.org/archives/hal/attachments/20061127/b0e50d9b/attachment.html


More information about the hal mailing list