[PATCH] Getter for the powersave state

David Zeuthen david at fubar.dk
Tue Nov 28 09:53:38 PST 2006


On Mon, 2006-11-27 at 21:55 +0100, Kevin Ottens wrote:
> Le Lundi 27 Novembre 2006 18:58, David Zeuthen a écrit :
> > Wouldn't it be better with a GetPowerSave method?
> 
> Well, actually I'm fine with simply a property because it is consistent with 
> most data available in HAL, and since I have to store this state somewhere 
> anyway.
> 
> If required we can add a GetPowerSave method, but it'll probably simply return 
> the property value.

I think we want the GetPowerSave() method rather than a property for the
following reasons

 1. Symmetry
 2. Same overhead as GetProperty()
 3. The reasons Danny mentioned
 4. Implementation GetPowerSave() will lookup in /sys (on Linux) instead
    of just using a property; hence we'll be able to cope with
    situations where users manually change it from a shell or using
    system(3) :-)

     David




More information about the hal mailing list