Add support for /sys/class/backlight
Richard Hughes
hughsient at gmail.com
Thu Oct 5 15:10:45 PDT 2006
On Thu, 2006-10-05 at 23:52 +0200, Holger Macht wrote:
> Patch adding support for the /sys/class/backlight interface. If
> available,
> a device /org/freedesktop/Hal/devices/computer_backlight is created.
> The
> patch adds a class device and adjusts the scripts for the methods
> GetBrightness and SetBrightness on the interface
> org.freedesktop.Hal.Device.LaptopPanel. As soon as all kernel drivers
> are
> converted to the new interface, we may drop the vendor specific code
> in
> acpi.c.
You mean the kernel guys actually agreed on a half decent
abstraction? :-)
Looks good to me, although I'm a little concerned we might have both the
backlight and the vendor specific files in the kernel and thus hal would
pick up both as laptop_panels.
Also, when we have a nice standard interface, perhaps we should aim to
use a C addon rather than execute scripts (as it's probably quicker and
we don't keep executing bash). Maybe crack, as davidz would say.
Richard.
More information about the hal
mailing list