Add support for /sys/class/backlight

Holger Macht hmacht at suse.de
Thu Oct 5 15:37:36 PDT 2006


On Thu 05. Oct - 23:30:02, Richard Hughes wrote:
> On Fri, 2006-10-06 at 00:21 +0200, Holger Macht wrote:
> > On Thu 05. Oct - 23:10:45, Richard Hughes wrote:
> > > On Thu, 2006-10-05 at 23:52 +0200, Holger Macht wrote:
> > > > Patch adding support for the /sys/class/backlight interface. If
> > > > available,
> > > > a device /org/freedesktop/Hal/devices/computer_backlight is created.
> > > > The
> > > > patch adds a class device and adjusts the scripts for the methods
> > > > GetBrightness and SetBrightness on the interface
> > > > org.freedesktop.Hal.Device.LaptopPanel. As soon as all kernel drivers
> > > > are
> > > > converted to the new interface, we may drop the vendor specific code
> > > > in
> > > > acpi.c.
> > > 
> > > You mean the kernel guys actually agreed on a half decent
> > > abstraction? :-)
> > > 
> > > Looks good to me, although I'm a little concerned we might have both the
> > > backlight and the vendor specific files in the kernel and thus hal would
> > > pick up both as laptop_panels.
> > 
> > Yes, so we might want to mention the old interface as obsolete in the spec
> > and keep it some time for compatibility?
> 
> By interface, you mean "the old way of getting the data" rather than a
> dbus interface right?

Yes, with interface I actually ment the device
/org/freedesktop/Hal/devices/acpi_brightness ;-)

Regards,
	Holger


More information about the hal mailing list