HAL & Thinkpads: additional hardware brightness

[Tomasz Torcz]

On Fri, Oct 06, 2006 at 11:42:18AM +0100, Richard Hughes wrote:
> On Thu, 2006-10-05 at 19:47 +0200, Tomasz Torcz wrote:
> >   first thing, match to set brightness_in_hardware in
> > 10-laptop-panel-mgmt-policy.fdi is not wide enough. I have TP z61t,
> > and
> > I had to add:
> > <match
> > key="/org/freedesktop/Hal/devices/computer:smbios.system.manufacturer"
> > string="LENOVO">
> > <match
> > key="/org/freedesktop/Hal/devices/computer:smbios.system.version"
> > string="ThinkPad Z61t">
> 
> Can you send a patch against CVS head please (with all the models that
> you know might be affected) and I'll apply it. I don't think we can
> blacklist LENOVO just yet. Thanks.

  I have patch ready for my z61t. I've asked owner of T60 to check this
fix. I hope he will do it in few days, then I can send a patch for T60.

-- 
Tomasz Torcz               "Never underestimate the bandwidth of a station
zdzichu at irc.-nie.spam-.pl    wagon filled with backup tapes." -- Jim Gray

-------------- next part --------------
diff -ur hal.orig/fdi/policy/10osvendor/10-laptop-panel-mgmt-policy.fdi hal/fdi/policy/10osvendor/10-laptop-panel-mgmt-policy.fdi
--- hal.orig/fdi/policy/10osvendor/10-laptop-panel-mgmt-policy.fdi	2006-10-06 13:15:55.000000000 +0200
+++ hal/fdi/policy/10osvendor/10-laptop-panel-mgmt-policy.fdi	2006-10-06 13:21:37.000000000 +0200
@@ -22,7 +22,7 @@
        but the hardware also synthesizes keypresses when the brightness is
        changed. This gives power manager software problems as the brightness
        can get into a feedback state so the panel flashes uncontrollably.
-       This is a hardware "feature" seen on IBM x31 laptops. -->
+       This is a hardware "feature" seen on IBM x31 and Lenovo z61t laptops. -->
   <device>
     <match key="info.category" string="laptop_panel">
       <match key="/org/freedesktop/Hal/devices/computer:smbios.system.manufacturer" string="IBM">
@@ -30,6 +30,11 @@
           <merge key="laptop_panel.brightness_in_hardware" type="bool">true</merge>
         </match>
       </match>
+      <match key="/org/freedesktop/Hal/devices/computer:smbios.system.manufacturer" string="LENOVO">
+        <match key="/org/freedesktop/Hal/devices/computer:smbios.system.version" string="ThinkPad Z31t">
+          <merge key="laptop_panel.brightness_in_hardware" type="bool">true</merge>
+        </match>
+      </match>
     </match>
   </device>