New patch! Re: HAL & Thinkpads: additional hardware brightness

[Richard Hughes]

On Tue, 2006-10-10 at 19:54 +0200, Tomasz Torcz wrote:
> On Tue, Oct 10, 2006 at 06:22:47PM +0100, Richard Hughes wrote:
> > On Fri, 2006-10-06 at 22:27 +0200, Tomasz Torcz wrote:
> > > On Fri, Oct 06, 2006 at 01:28:04PM +0200, Tomasz Torcz wrote:
> > > > On Fri, Oct 06, 2006 at 11:42:18AM +0100, Richard Hughes wrote:
> > > > > On Thu, 2006-10-05 at 19:47 +0200, Tomasz Torcz wrote:
> > > > > >   first thing, match to set brightness_in_hardware in
> > > > > > 10-laptop-panel-mgmt-policy.fdi is not wide enough. I have TP z61t,
> > > > > > and
> > > > > > I had to add:
> > > > > > <match
> > > > > > key="/org/freedesktop/Hal/devices/computer:smbios.system.manufacturer"
> > > > > > string="LENOVO">
> > > > > > <match
> > > > > > key="/org/freedesktop/Hal/devices/computer:smbios.system.version"
> > > > > > string="ThinkPad Z61t">
> > > > > 
> > > > > Can you send a patch against CVS head please (with all the models that
> > > > > you know might be affected) and I'll apply it. I don't think we can
> > > > > blacklist LENOVO just yet. Thanks.
> > > > 
> > > >   I have patch ready for my z61t. I've asked owner of T60 to check this
> > > > fix. I hope he will do it in few days, then I can send a patch for T60.
> > > 
> > >   I got confirmation that this is needed for Thinkpad T60 also. See
> > > comments at https://launchpad.net/distros/ubuntu/+source/hal/+bug/61184
> > 
> > I've committed both of these, many thanks. If you find anymore, then
> > please let us know! Thanks.
> 
>   Ross Burton comments:
> #v+
> This is also required for the X60 and I imagine the X60s.
> 
>   smbios.system.version = 'ThinkPad X60' (string)
> 
> Might be best to match on "ThinkPad .6[0-9]s?"...
> #v-

Okay, I'll add those too. I think we'll continue with the
version-at-a-time approach until we see a definite pattern.

Thanks,

Richard.