[PATCH] acpi.c: fix for fd.o bug #8593 and small cleanup

Richard Hughes hughsient at gmail.com
Thu Oct 12 08:10:55 PDT 2006


On Thu, 2006-10-12 at 17:04 +0200, Danny Kukawka wrote:
> Hi,
> 
> this patch fixes the fd.o bug #8593 where wrong low current voltage battery 
> values causes a wrong remaining percentage. 

Sounds sane, but what is causing the low voltage out of interest? Broken
ACPI / broken BIOS or broken EC?

> Now we assume if the current voltage is lower than 50% of the design voltage 
> that this is from broken hardware and use the design voltage to normalise the 
> battery values. 
> 
> I also included some little cleanups in acpi.c and removed duplicated code.

Looks good to me I guess.

Richard.




More information about the hal mailing list