[patch] Fixing ACPI to ignore the special 'Ones' value

Danny Kukawka danny.kukawka at web.de
Sun Oct 29 07:53:14 PST 2006


On Saturday 28 October 2006 23:46, Richard Hughes wrote:
> As discovered in : http://bugzilla.gnome.org/show_bug.cgi?id=348201
>
> ACPI gives out the special 'Ones' value for rate when it's unable to
> calculate the true rate.
>
> We should set the rate zero, and wait for the BIOS to stabilise for the
> few BIOS's that give 0xffff as the very first entry after an AC state
> change.

Some comments:

1.) you should not depend on the remaining time to shutdown the machine, but 
on the remaining percentage which is much more reliable.

2.) Not sure if this fix is correct, because there could also be machines wich 
report this value as normal and correct value (my machine e.g. report 46058 
mW ... there is not so much until this value)

3.) You should not change the value of battery.reporting.rate because this is 
the value the machine report. If you would like to change a value, you have 
to change battery.charge_level.current.

Danny


More information about the hal mailing list