[PATCH] FDI fixes for newer MacBookPro models

David Zeuthen david at fubar.dk
Wed Apr 18 12:30:58 PDT 2007


On Wed, 2007-04-18 at 10:49 +0200, Danny Kukawka wrote:
> On Mittwoch, 18. April 2007, Martin Pitt wrote:
> > Hi,
> > 
> > Matthew recently fixed the FDIs to support newer MacBook Pro models.
> > 
> > Patch applies cleanly to 0.5.9 and git head.
> > 
> > Thanks for considering,
> 
> 1) smbios.system.product is deprecated use system.hardware.product
>    instead
> 2) Wouldn't it make sense to check simply if system.hardware.product
>    contains MacBookPro as string? See attached patch.

That's a bit dangerous; what happens if a newer Macbook Pro ships with a
different register layout?

     David




More information about the hal mailing list