get rid of acpid and provide /var/run/acpid.socket by the hald-acpi-addon

Kay Sievers kay.sievers at vrfy.org
Thu Aug 9 05:04:29 PDT 2007


On 8/9/07, Danny Kukawka <danny.kukawka at web.de> wrote:
> On Mittwoch, 8. August 2007, Kay Sievers wrote:
> > With the upcoming ACPI module autoloading, the ACPI sysfs representatin
> > and events, the ACPI events passed to the input layer, and the HAL
> > support for the events, it's time to get rid of the acpid daemon.
> >
> > The attached patch implements the multiplexer logic of acpid in the hal
> > ACPI addon. That way, distros who care, can optionally get rid of the
> > acpid daemon, and still provide the events for tools who still depend on
> > it, as long as needed.
> >
> > If HAL is compiled with the support to listen directly to the kernel
> > events and acpid is not running during HAL startup, HAL will open the
> > kernel events interface and multiplex the events to listeners at the
> > /var.run/acpid.socket, just like acpid was doing it.
>
> Without any test two comments:
>
> [...]
> +#include <sys/socket.h>
> +#include <sys/poll.h>
> +#include <glib-2.0/glib.h>
>
> IMO it should be simply '#include <glib.h>'
>
> ---------------------------------------------------
> [...]
>         dbus_error_init (&error);
>         if (!libhal_device_addon_is_ready (ctx, getenv ("UDI"), &error)) {
> +               HAL_ERROR (("libhal_device_addon_is_ready == FALSE"));
>                 return 1;
>         }
>
> we can remove the (second) 'dbus_error_init (&error);' in main() because we
> never reach this code if the error was already set before.

Yep, both fixed.

Thanks,
Kay


More information about the hal mailing list