[PATCH] fix detection of storage.cdrom.*_speed* values (fd.o 10399)

David Zeuthen davidz at redhat.com
Tue Aug 28 11:01:02 PDT 2007


On Tue, 2007-08-28 at 19:05 +0200, Danny Kukawka wrote:
> On Dienstag, 28. August 2007, David Zeuthen wrote:
> > On Wed, 2007-08-22 at 20:22 +0200, Danny Kukawka wrote:
> > > Hi,
> > >
> > > the attached patch fixes the in fd.o #10399 reorted problem that the
> > > following properties get never updated on media changes:
> > >  * storage.cdrom.read_speed (int)
> > >  * storage.cdrom.write_speed (int)
> > >  * storage.cdrom.write_speeds (strlist)
> > >
> > > This patch depends my other patch to fix the strlist changeset handling.
> > > HAL update now also these properties on media changes to provide always
> > > up-to-date values.
> >
> > This seems reasonable. In retrospect this should probably be properties
> > of the media then. Oh well. Please commit. Thanks.
> 
> Not sure if they should be properties of the media. They say what the CD/DVD 
> burner support for this (kind of ?) media, not sure if it also say what the 
> media itself really support. 

Yeah, probably. I was just brainfarting. It happens :-)

> Commited.

Thanks for this.

      David




More information about the hal mailing list