[Patch] Fix strlist to string conversion
Rob Taylor
rob.taylor at codethink.co.uk
Tue Dec 4 03:21:24 PST 2007
Sjoerd Simons wrote:
> Hi,
>
> Attached patch converts the strlist to string code to use of a GString
> instead of a static buf and strncpy. The strncpy code has the well known
> issue of not '\0' terminating strings on overflow.
>
> See the patch for more info. Ok to commit ?
This seems ok to me. Its obviously a bit heavier and more
fragmentation-prone than the previous code, but I don't believe this is
called frequently enough to make this an issue. Please commit :)
Thanks,
Rob
> Sjoerd
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> hal mailing list
> hal at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/hal
--
Rob Taylor, Codethink Ltd. - http://codethink.co.uk
More information about the hal
mailing list