[PATCH] Add zsh completion to PolicyKit and make completion optional

David Zeuthen david at fubar.dk
Thu Dec 6 11:18:40 PST 2007


On Thu, 2007-12-06 at 08:43 -0500, Doug Klima wrote:
> Saleem Abdulrasool wrote:
> > Hi.
> > 
> > Attached is a patch for adding zsh completion support to policykit.  It also
> > allows you to enable/disable completion for both bash and zsh for installation.
> > 
> > 
> > 
> > ------------------------------------------------------------------------
> > 
> > _______________________________________________
> > hal mailing list
> > hal at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/hal
> 
> Ok to commit?
> 
> I was hoping to commit this for 0.7 but looks like that didn't happen.
> 

Yeah, sorry about that; I saw it earlier and wanted to reply but got
away from doing that. I'm a bit reluctant to take this just yet as the
commandline tools are still in flux. 

However if someone steps up to maintaining it (this includes keeping up
with the changes) I guess it's fine to commit. Alternative we can put it
in a contrib directory or something?

Comments on the patch itself: I don't use zsh myself so the only thing I
can comment is the build system patches. And they look fine. It probably
needs an update similar to

http://gitweb.freedesktop.org/?p=PolicyKit.git;a=commitdiff;h=dd2c0163b5a1b429a4957b41d2c4cdc2db5cafe6

Thanks.

     David




More information about the hal mailing list