PolicyKit releases and !AWOL

Marcel Holtmann marcel at holtmann.org
Thu Dec 6 16:42:28 PST 2007


Hi David,

>> The PK changelog mentions as highlight, that the glib dependency  
>> was removed.
>> Instead you implemented your on sortof glib, called libkit.
>> I don't see the real benefit here, smells a bit of NIH. glib is a
>> rather well tested lib and already used in the utopia stack. Could  
>> you
>> elaborate a bit on that decision?
>
> Sure. Two things.
>
> First, in order for libpolkit to be useful in projects like dbus
> (specifically the bus) and X.org it needs to handle OOM. And glib  
> can't
> do that; the glib API is not designed to do that. And that's fine.

you know that GLib has g_try_malloc and friends? These can be used to  
detect OOM.

> Seriously, libkit is 4700 lines of C including 100% doc coverage and  
> 91%
> test coverage. It's hardly reinventing glib.

I haven't reviewed your libkit at all, but be careful with it. The  
BlueZ project tried to avoid GLib and now we have eglib which is  
basically a stripped down GLib. Starting with the next major version  
number I am going back to GLib since the maintenance overhead of eglib  
is too much. It started out very small and simple, but over time this  
changed.

Regards

Marcel



More information about the hal mailing list