PolicyKit releases and !AWOL

[Michael Biebl]

2007/12/6, David Zeuthen <david at fubar.dk>:
>
> On Thu, 2007-12-06 at 17:13 +0100, Michael Biebl wrote:
> > 2007/12/6, David Zeuthen <david at fubar.dk>:
>
> > PK-gnome failes to compile with -Wl,--as-needed, a -lpolkit-grant is missing.
> > Please find the attached patch.
>
> I know that in PolicyKit we set these automatically. How about a patch
> to do the same for PK-gnome? Thanks.

I saw you commit the patch, thanks.

I got another patch for PK-gnome (attached), which sets the correct
categories for the polkit-gnome-authorization desktop file.


> > > Also, packagers should be careful, there's a few new setgid helpers; the
> > > blurb at the end of ./configure should be useful. And here's the Fedora
> > > spec files for reference
> >
> > "polkit-set-default-helper" seems to be missing in the blurb at the
> > end of ./configure.
>
> I'll fix that.

Some more comments:
1.) /var/lib/misc/PolicyKit.reload should be mode 644, it's not an
executable or script.
2.) $(libexecdir)/polkit-grant-helper-pam should be world readable,
4754. You don't gain extra security by making it non-readable. see
also [1].

> > The PK changelog mentions as highlight, that the glib dependency was removed.
> > Instead you implemented your on sortof glib, called libkit.
> > I don't see the real benefit here, smells a bit of NIH. glib is a
> > rather well tested lib and already used in the utopia stack. Could you
> > elaborate a bit on that decision?
>
> Sure. Two things.
>
> First, in order for libpolkit to be useful in projects like dbus
> (specifically the bus) and X.org it needs to handle OOM. And glib can't
> do that; the glib API is not designed to do that. And that's fine.
>
> Seriously, libkit is 4700 lines of C including 100% doc coverage and 91%
> test coverage. It's hardly reinventing glib.

Ok, fair enough. Thanks for the explanations.
Although I agree with the others that ideally glib is fixed to let
applications handle OOM situations, I don't know glib well enough if
that is feasible.

Cheers,
Michael


[1] http://www.debian.org/doc/debian-policy/ch-files.html#s10.9
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PK-gnome-categories.patch
Type: text/x-patch
Size: 461 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20071210/736f666e/attachment.bin