[PATCH] Don't fail if polkit-policy-file-validate is not found

[Michael Biebl]

2007/12/6, David Zeuthen <david at fubar.dk>:
>
> On Sat, 2007-12-01 at 18:18 +0100, Michael Biebl wrote:
> > 2007/12/1, Michael Biebl <mbiebl at gmail.com>:
> > > 2007/12/1, Michael Biebl <mbiebl at gmail.com>:
> > > > Hi,
> > > >
> > > > the configure check for polkit-policy-file-validate is not strictly
> > > > necessary for successully compiling the package. It's only needed if
> > > > you want to run "make check" or "make distcheck" (and as such mainly
> > > > interesting for creating the dist tarball).
> > > > The attached patch makes ./configure not fail, if the tool is not
> > > > found, but instead print a big warning at the end of the configure
> > > > run.
> > >
> > > Hm, another possibility would be, to not run the checks in
> > > policy/Makefile.am, when polkit-policy-file-validate is not found (but
> > > print the warning message instead).
> > > This way "make (dist)check" would pass, even when
> > > polkit-policy-file-validate is not installed.
> >
> > Please find attached a patch for this second approach (which I would prefer).
>
> Hmm.. I kinda disagree on this patch. I mean, I wrote the validation
> program for a reason. To check for bugs. Maybe if you can explain why a
> minimal build environment is more important than correctness I'd be
> willing to apply it... (this is not a troll; sorry if it sounds like
> like it).

polkit-policy-file-validate is not required for successfully compiling
hal, so why should we abort ./configure then?. The checks are only
interesting for developers that run make (dis)check resp. for you,
when you release a tarball, where polkit-policy-file-validate is still
used. So you still get your validation before release. Best of both,
so to speak.
If you use the first patch I posted, make check will abort if you
haven't installed polkit-policy-file-validate. So it can't go
unnoticed.

It's simply a waste of ressources, if you have to build-depend on the
complete PK package in hal, and all our build daemons have to install
the package, and it's never used during compilation.

Cheers,
Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?