[PATCH 0/3 v2] PolicyKit - Add Shadow authorisation framework

[Carlos Corbacho]

On Monday 17 December 2007 02:34:05 David Zeuthen wrote:
>  - Kindly change the license so it's MIT/X11 to fit with the
>    rest of the project (I recently relicensed everything)

Piter - this one's yours.

>  - Please use the same coding standard as the other code (space
>    between function and opening parenthesis; brace for function
>    start on a separate line; parenthesis around operand for the
>    sizeof operator etc.)

I can fix this.

>  - Really need to do a "sleep (2);" on the wrong password to discourage
>    an attack where one is hammering the system with different passwords
>    (polkit-grant-helper relies on the authentication framework (e.g.
>    PAM) doing this) [1]

Easily fixed. Although the file you quote uses sleep(10). Should we go 2, 10, 
or in the middle with 5?

-Carlos
-- 
E-Mail: carlos at strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D