[PATCH] fix .hal-mtab mountpoint handling

David Zeuthen david at fubar.dk
Thu Feb 15 11:41:53 PST 2007

On Mon, 2007-02-12 at 17:44 +0100, Danny Kukawka wrote:
> Hi,
> this patch fixes problems with the mountpoint handling in .hal-mtab and non 
> ASCII chars as e.g. in languages like Russian. This patch remove the, IMO not 
> needed, usage of g_strescape() to escape the mountpoint for .hal-mtab.
> Tested this with the string from [1] (also reported as fd.o bug #9921) and 
> normal ASCII label names (also with space characters in the mountpoint) and 
> there was no problem and both cases worked as expected for mount and umount 
> now.
> Please review.

Yes, this looks good. My only concern, initially when looking at the
patch, was that the mount point might contain newlines but we already
check that it doesn't. Please commit. Thanks!


More information about the hal mailing list